-
Notifications
You must be signed in to change notification settings - Fork 954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove query parameters from URI #758
Conversation
The |
I saw that the current function does filter out queries but only from urls. The update I made to _get_id makes sure to also filter it out from URI. With the |
That's because |
It seems that some of my users take the url, transform it themself in Uri, but forget to remove the queries from the original link. I never had that problem personally, that's why we just got an issue last week for that and never had to bother with it before. If I have some user that can do it, there might be other project with similar issue. Filtering out the query doesn't affect anything other than removing the bad element provided by the user. |
Yeah, this is more a usage issue as the URI is incorrect, but at the same time it wouldn't hurt to clean up the URI inside spotipy too. Happy to merge this if you manage to fix the checks! |
* made _get_id take account of ? in URI * corrected typo * changes to _get_id explained
#757
This PR adds a split to the _get_id function to make sure an URI provided by the user removes any element following an interrogation mark to only return the id element of the URI.